On Tue, Sep 4, 2018 at 3:02 PM Daniel Krenn <kr...@aon.at> wrote: > > On 09/04/2018 02:33 PM, Jeroen Demeyer wrote: > > Let me make one important comment (something that I've said before > > though): a large part of what makes the current workflow work is not so > > much Trac itself but our git server and the "git trac" scripts. > > > > For example, I very much like the fact that we have a single git repo > > where all pull requests appear. Checking out a pull request for > > reviewing is so much easier with Sage than it is with typical GitHub > > projects. If we ever move to GitLab, we really should keep this workflow. > > This should not be a problem (i.e. adapting git-trac to a git-gitlab) as > Gitlab has a convenient API. > > See, for example, > https://docs.gitlab.com/ee/api/merge_requests.html#get-single-mr > which provides all information needed.
Here's a real world sample of using the GitLab API from the GitLab<->Trac bot. In particular, linked is the method that closes a merge request if the associated Trac ticket is closed. It's fairly simple: https://github.com/sagemath/sage_trac_plugin/blob/master/sage_trac/gitlab.py#L416 And it would be even simpler if I were using the Python API that exists for GitLab; here I was just lazy about it, and wanted to get more direct experience with the HTTP API directly (since it was only for a few simple cases) before switching over to the higher-level Pythonic API. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
