On 03/16/2017 12:26 AM, Ralf Stephan wrote: > The author of 1234 has IMO the responsibility to monitor 987 and do > timely updates of 1234 when 987 changes, including canceling the > positive flag on 1234. >
I don't want to beat this to death, but if the author of 1234 is so vigilant, why can't he just switch 1234 to "positive review" when 987 is finished? The only interesting case is when things don't go as expected. If you set 1234 to "positive review", then you're counting on the author/reviewer to (1) be paying attention (2) be receiving trac emails (3) not be busy (4) remember what the ticket was about (5) fix any problems before it gets merged If any of those fail, then 1234 could get merged with problems. By leaving 1234 to "needs review", the default mode is safety: nothing bad can happen after 987 gets merged. And if the author/reviewer (1) is paying attention (2) is receiving trac emails (3) is not busy (4) remembers what the ticket was about (5) fixes any problems then 1234 will immediately get set to "positive review" and you're no worse off. On the other hand, if any of those bullet points fail, you almost certainly want 1234 to be "needs review." Maybe there are safe cases, I don't know. Ultimately the only real quality control measure we have is the reputation of the author and reviewer. I would personally be embarrassed if I set something to "positive review" based on nonexistent code, and it crashed and burned. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
