On 2016-10-12 12:47, Jori Mäntysalo wrote:
After #21687 there are 341 lines in 172 files with

except Exception:

What can happen in, say has_vertex() in generic graphs, when it has the
code

     try:
         hash(vertex)
     except Exception:
         return False
     return self._backend.has_vertex(vertex)

I.e. what if hash() runs out of memory or something like that?

What you expect. A MemoryError will be raised, which is caught by the "except Exception".

So I agree that code like the above is bad (but not nearly as bad as a bare "except:")

--
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

Reply via email to