On Mon, Sep 26, 2016 at 6:55 PM, Jonathan Bober <jwbo...@gmail.com> wrote: > On Mon, Sep 26, 2016 at 11:52 PM, William Stein <wst...@gmail.com> wrote: >> >> On Mon, Sep 26, 2016 at 3:27 PM, Jonathan Bober <jwbo...@gmail.com> wrote: >> > In the matrix_integer_dense charpoly() function, there is a note in the >> > docstring which says "Linbox charpoly disabled on 64-bit machines, since >> > it >> > hangs in many cases." >> > >> > As far as I can tell, that is not true, in the sense that (1) I have >> > 64-bit >> > machines, and Linbox charpoly is not disabled, (2) >> > charpoly(algorithm='flint') is so horribly broken that if it were ever >> > used >> > it should be quickly noticed that it is broken, and (3) I can't see >> > anywhere >> > where it is actually disabled. >> > >> > So I actually just submitted a patch which removes this note while >> > fixing >> > point (2). (Trac #21596). >> > >> > However... >> > >> > In some testing I'm noticing problems with charpoly(), so I'm wondering >> > where that message came from, and who knows something about it. >> >> Do you know about "git blame", or the "blame" button when viewing any >> file here: https://github.com/sagemath/sage/tree/master/src > > > Ah, yes. Of course I know about that. And it was you! > > You added that message here:
Dang... I had a bad feeling that would be the conclusion :-) In my defense, Linbox/FLINT have themselves changed a lot over the years... We added Linbox in 2007, I think. -- William (http://wstein.org) -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
