Hi all,

Several of you have had issues updating your SSH keys in Trac since
the server upgrade (or adding new keys for new users).

(I hope) the issue is resolved now, and I would like to give a brief
post-mortem on the issue:

- gitolite, the software that manages authorization for the git
repository via SSH, was installed with a somewhat old version from
Ubuntu's apt repository

- gitolite throws a fit and fails to update its list of authorized
keys if an invalid SSH key is added to its key repository

- Andrew Ohana tells me at one point (we're not sure) he might have
applied a patch to gitolite to make it more flexible with respect to
invalid keys (throw a warning instead of die entirely); not clear if
that patch would already exist in a newer version of gitolite or if
this is still non-standard

- additionally, there was a bug in Trac plugin for Sage that made it
override any manual changes I made to the gitolite key repository
(i.e. to remove invalid keys), so every time someone added a new key
all the invalid keys I had deleted are restored as well

- I fixed the above bug in the Trac plugin [1] and have also added a
modicum of validation of SSH keys added through the web interface [2]
so that this issue should not recur.

Thanks for your patience,
Erik

P.S. In the process of working on this someone (Dima, I think)
suggested adding an interface to add your SSH key from the command
line via `git trac`.  I think it's a great idea, and something I'll
consider in the future if there's more demand.  I also want to
overhaul the web UI for managing SSH keys (make it more like GitHub)
but I'll need a quiet rainy day for that.


[1] 
https://github.com/sagemath/sage_trac_plugin/commit/abd272c292f985fb0adcdf537668642dd3a9b31a
[2] 
https://github.com/sagemath/sage_trac_plugin/commit/6b718e564c0c37430fd9d98aef7d29c4ea7191d8

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

Reply via email to