On Tuesday, 22 September 2015 11:49:37 UTC-7, William wrote: > > On Tue, Sep 22, 2015 at 11:12 AM, Dima Pasechnik <dim...@gmail.com > <javascript:>> wrote: > > >> Who? > >> Is he removing his own name or other people's name? > > > > see done by the request of the reviewer > > Nathann Cohen seems to have written: > > "what is this?" about this in your patch: "+- cf. ``git blame`` for > the others involved" > > Then there was some bizarre banter starting with "It committed suicide > last month, but through an exorcist I was..." > > > > http://git.sagemath.org/sage.git/commit/?id=edb886e9f9d0f505f272fe769e69e8a51ab265df > > > on http://trac.sagemath.org/ticket/19098 > > > > One way or another, there are Copyright notices with names in many > files, > > and Author entries, > > True. As there should be. Contributors keep their copyright. > Authors should get as much and as explicit of credit as we can > possibly give them. > > People probably don't remember the early days of Sage, but there was > often a belief that the project would be *impossible* due to the math > culture in which authorship had to be clearly maintained. Many people > sincerely thought that the GAP or PARI developers would be very angry > that their system was used in Sage, and that people wouldn't > contribute since their contributions wouldn't be acknowledged. > > > sometimes they > > have to do something with each other, sometimes not, sometimes there are > > huge additions done > > by people without adding their names to either of these fields... > > It's a mess. > > I don't think we should impose a ton of bureaucracy on the AUTHORS blocks. > > However, we should definitely not have reviewers asking people to > remove their names from it, and not removing other people's names > either. > > this is not enough, as non-mentioning your name has a viral effect - people won't feel like putting their names in the AUTHORS block if there is none, or if it is obsolete. One example is provided by src/sage/graphs/generators/families.py (featured in the commit above) more examples: sage/combinat/matrices/hadamard.py (Only 50% is by wdj, in AUTHORS)
more extreme: sage/numerical/mip.pyx (it has Nathann's name in copyright - I guess he cared more about acknowledgements, as he was still a postdoc, IIRC...) The only AUTHORS listed is my former student Risan, now at Facebook... I don't know how widespread this is, absence/incompleteness of AUTHORS. Probably some automated check should be run, comparing output of 'git blame' with AUTHORS. Dima -- William > > > > > > >>> > >>> IMHO we need an official policy on this. > >>> > >>> > >>>> > >>>> -- William > >>>> > >>>> > documentation but these information, like TODO and TESTS, is not > >>>> > usually > >>>> > what the user expects to see in the doc. These developer-oriented > >>>> > blocks > >>>> > are better to be hidden or placed in less prominent place for the > end > >>>> > users. > >>>> > > >>>> > -- > >>>> > You received this message because you are subscribed to the Google > >>>> > Groups > >>>> > "sage-devel" group. > >>>> > To unsubscribe from this group and stop receiving emails from it, > send > >>>> > an > >>>> > email to sage-devel+...@googlegroups.com. > >>>> > To post to this group, send email to sage-...@googlegroups.com. > >>>> > Visit this group at http://groups.google.com/group/sage-devel. > >>>> > For more options, visit https://groups.google.com/d/optout. > >>>> > >>>> > >>>> > >>>> -- > >>>> William (http://wstein.org) > >>> > >>> -- > >>> You received this message because you are subscribed to the Google > Groups > >>> "sage-devel" group. > >>> To unsubscribe from this group and stop receiving emails from it, send > an > >>> email to sage-devel+...@googlegroups.com <javascript:>. > >>> To post to this group, send email to sage-...@googlegroups.com > <javascript:>. > >>> Visit this group at http://groups.google.com/group/sage-devel. > >>> For more options, visit https://groups.google.com/d/optout. > >> > >> > >> > >> -- > >> Sent from my massive iPhone 6 plus. > > > > -- > > You received this message because you are subscribed to the Google > Groups > > "sage-devel" group. > > To unsubscribe from this group and stop receiving emails from it, send > an > > email to sage-devel+...@googlegroups.com <javascript:>. > > To post to this group, send email to sage-...@googlegroups.com > <javascript:>. > > Visit this group at http://groups.google.com/group/sage-devel. > > For more options, visit https://groups.google.com/d/optout. > > > > -- > William (http://wstein.org) > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
