Hello Vincent,
I do actually prefer to keep both with different semantics (so I guess
it is answer 5.).
- "inplace" should be used when the object is being modified within a
method (i.e. G.cut_me_in_pieces(inplace=True) will modify G)
- "copy" should be used when we want to specify whether or not we want
to copy the arguments being used in the function (i.e.
MyNewObject(data=[1,2,3], copy=False) then the created oject will hold a
reference to the list [1,2,3] given in input)
Vincent
On 21/08/15 20:08, Vincent Delecroix wrote:
Hello,
While looking at #18481, I realized that we have two argument names that
have the same purpose: "copy" and "inplace" (one being the contrary of
the other of course). As it is worth a convention, I am just asking for
your preferences:
1. It does not matter
2. Functions should accept both, ie both my_function(copy=True) and
my_function(inplace=True) should work
2. "inplace" is better
3. "copy" is better
4. we need another argument name
5. ?
Best,
Vincent
--
You received this message because you are subscribed to the Google Groups
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at http://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.
