On Thu, May 29, 2014 at 2:22 PM, leif <not.rea...@online.de> wrote: > kcrisman wrote: >> >> <rant> >> Git workflow. >> >> The goal was to reduce work for some developers and make things more >> modular, but in fact what happens is that people are basing their >> "branches" on all kinds of different starting points, forcing constant >> recompilation for even the most trivial changes. [...] </rant> > > Nobody ever promised it would make *reviewers'* life easier.
Making the reviewer's life easier should be a primary goal as well--look at the number of unreviewed tickets sitting on trac right now. Previously, we still had people basing their "branches" on all kinds of different starting points, but it was all implicit, so it was harder to look at and test exactly the code someone else intended to be contributing. If I understand your complaint correctly, the problem is that re-compiling after switching branches is too expensive. http://trac.sagemath.org/ticket/14372 needs to be resolved. I would note that for most trivial changes there's no need to download and build/test it yourself--the patchbot should do this for you. Of course sometimes you want to try out (and contribute back!) different corner cases, bigger examples, etc. but that's not essential for many reviews. It would be very cool if there was a way to have multiple builds of Sage co-exist cheaply. Imagine a service where you could ssh into trac1234.sagemath.org and be presented with a sage prompt with ticket #1234 built and ready to play with. Or a notebook. How cheap could it be to have a SMC project for every open ticket? And then you could take some of your examples and insanely easily (e.g. with the click of a button, or maybe a copy-paste) add them to a docstring. That's my vision of how to make life easier for reviewers on top of what the patchbot already does. - Robert -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
