I don't care wrt patchbot. ApplyFailed with patchbot is cheap. Ah, we could ignore testing tickets that have failed to apply once.
However, as you know, reviewing is a scarce resource, and scaring reviewers with a conflicting patch is not nice. Also, having a reliable label that shows the author cares would help. On Tue, May 20, 2014 at 9:09 AM, Nathann Cohen <nathann.co...@gmail.com>wrote: > And set the ticket to needs-work, *beg*... > > > You also have to consider that setting tickets to needs_work when there is > nobody to review them creates a LOT of (potentially useless) work. > > No offense intended, but you set something like 4-5 of my branches to > needs_work yesterday, I fixed them right afterwards, and because there is > nobody to review the tickets, the branches will just stay there and be > broken again by a later version of Sage. > > Aaaaaaaand if we have to rebase them for each version of Sage only to wait > for somebody to come and review them, it will really require a lot of > useless work. > > While waiting for a reviewer to come and say "this ticket needs to be > rebased" only makes us fix conflicts when there is a point. > > Most of the time, by the way, the code can be read and understood by the > reviewer while the author rebases the branch. So there is no time loss > there that I fear. > > Nathann > > -- > You received this message because you are subscribed to a topic in the > Google Groups "sage-devel" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/sage-devel/vXK5K1IkQik/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > sage-devel+unsubscr...@googlegroups.com. > To post to this group, send email to sage-devel@googlegroups.com. > Visit this group at http://groups.google.com/group/sage-devel. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
