William Stein wrote:
Hi Sage-Devel,
Did we change the build system so patches are applied in alphabetical
order by name? That seems like a possibly bad idea. For example,
yesterday a student in my class fixed a bug in pexect [1], which
involved patching, and the moment I saw the diff [2], I was suspicious
because the patch application order was nowhere specified. Indeed, on
testing, it failed for that very reason. Shouldn't the order of the
patches we apply be explicitly specified in a file... or if it is by
date, we should require the patch filename to start with an ISO
timestamp. Just curious.
Well, not "the build system", but in spkg-install scripts (here
pexpect's), we usually have
# Apply patches
for patch in ../patches/*.patch; do
patch -p1 <"$patch"
if [ $? -ne 0 ]; then
echo >&2 "Error applying '$patch'"
exit 1
fi
done
since about three years? ;-) (I think Jeroen started doing it that way.)
So if patches have to be applied in a specific order (which is rarely
the case), we use e.g. patches/01_foo.patch patches/02_bar.patch etc.
-leif
[1] http://trac.sagemath.org/ticket/15178
[2]
http://git.sagemath.org/sage.git/commit/?h=5bd09123dafcf5df768a02365f6df93a44087777&id=815dd05a67da0f011928c04db72d29fb812d8916
--
() The ASCII Ribbon Campaign
/\ Help Cure HTML E-Mail
--
You received this message because you are subscribed to the Google Groups
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at http://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.
