If you think it is correct then we can merge it. Its also an interesting test case in how well git deals with merge conflicts. In my experience it has always done an exceptionally good job at that...
On Friday, February 7, 2014 9:55:56 AM UTC, Nathann Cohen wrote: > > Sooooooooooooooo what do we do with this patch ? And why don't we run 2to3 > on everything at once, to settle it once and for all ? > > Nathann > > On Thursday, February 6, 2014 7:14:30 PM UTC+1, Volker Braun wrote: >> >> +1 for gradually switching to py3 syntax >> >> Its easy to get used to a print function. Old code can be auto-fixed with >> 2to3. >> >> >> >> On Thursday, February 6, 2014 4:48:51 PM UTC, Nathann Cohen wrote: >>> >>> Hello everybody ! >>> >>> My brain having shown its uselessness agsinst the problem I work on, I >>> was fishing for patches needing review. >>> >>> http://trac.sagemath.org/ticket/15784 >>> >>> What do we do with this ? >>> >>> 1) Do we care if something is not Python 3 compatible ? >>> 2) Do we care if a patch touches everything ? >>> >>> My answer to 2) is "I don't mind at all", and my answer to 1) is "I >>> don't mind either". The point is that I don't like to see patches waiting >>> forever for a review, especially when they will have to be rebased every >>> release, like this 15784. >>> >>> So what do we do with this ? Wontfix or Positive review ? >>> >>> Nathann >>> >>> P.S. : Oh. Well, I don't mind making stuff Python 3 compatible but it >>> looks like "print a" should be rewritten as "print(a)", and that's ugly :-P >>> >>> -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/groups/opt_out.
