On Fri, Jul 26, 2013 at 3:19 AM, David Loeffler <d.a.loeff...@warwick.ac.uk> wrote: > Hi Robert, > > That's excellent -- thanks! One question: there are some tickets (e.g. > #14366) where it is not picking up correctly information in the ticket > comments specifying which patches to apply. Is it possible that this > part of the patchbot's code has also been broken by the trac update?
For some reason there were some extra (unprinted) characters hanging on the end of that line in the comment. Specifically, utf-8 encoded http://unicode-table.com/en/search/?q=200b http://trac.sagemath.org/ticket/14366?format=rss Search for "Fri, 26 Jul 2013 09:55:29" to see your comment. No idea how they got here, when I added the same comment I saw nothing. (Did you copy and paste this from somewhere?) > (I suppose this will become moot soon anyway when we switch to git) Yes! > On 26 July 2013 08:26, Robert Bradshaw <rober...@gmail.com> wrote: >> This was due to the trac change. I've updated the patchbot to >> understand the this (and it's actually much cleaner as there are >> csv/tsv formats now so I don't have to parse the html). It'll take a >> while to actually update all the tickets in question. >> >> On Thu, Jul 25, 2013 at 2:32 AM, David Loeffler >> <d.a.loeff...@warwick.ac.uk> wrote: >>> Some further data: the problem is definitely with the patchbot server >>> process running at patchbot.sagemath.org -- if you request a list of all >>> tickets with >>> >>> http://patchbot.sagemath.org/ticket/?status=all&order=id&raw&pretty >>> >>> then it really does return all tickets, but for the majority of them, it >>> claims the ticket status is "unknown". >>> >>> David >>> >>> On Thursday, July 25, 2013 12:28:26 AM UTC+2, David Loeffler wrote: >>>> >>>> Hi folks, >>>> >>>> I'm at SD51 in Leiden this week, and it would be nice if we had a working >>>> sage patchbot to test the patches we're writing... >>>> >>>> At the moment there seems to be something rather odd going on with the >>>> patchbot. I have set a patchbot worker process running on one of our >>>> Warwick >>>> machines, but it seems to ignore most of the needs-review / positive-review >>>> patches, and instead skips to testing some ancient ones that are marked as >>>> needs-work or needs-info. >>>> >>>> Poking around in the code, it seems that the worker process runs through >>>> the list of tickets returned by the database query >>>> >>>> http://patchbot.sagemath.org/ticket/?raw&status=open >>>> >>>> This query only returns 241 tickets (while we actually have several >>>> thousand tickets open) and this list seems to only contain 10 of the 400 or >>>> so that are needs_review / positive_review. >>>> >>>> What's going on here? Is it just that the patchbot got hopelessly broken >>>> by the recent trac server update and nobody's tried to fix it yet? It does >>>> seem to be getting some live data from the trac server (the data returned >>>> includes ticket modification times, some of which are in the last few >>>> hours) >>>> but it's clearly somehow ignoring most of the tickets it should be >>>> returning. >>>> >>>> Can anyone diagnose what's causing this? >>>> >>>> David >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "sage-devel" group. >>> To unsubscribe from this group and stop receiving emails from it, send an >>> email to sage-devel+unsubscr...@googlegroups.com. >>> To post to this group, send email to sage-devel@googlegroups.com. >>> Visit this group at http://groups.google.com/group/sage-devel. >>> For more options, visit https://groups.google.com/groups/opt_out. >>> >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sage-devel" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to sage-devel+unsubscr...@googlegroups.com. >> To post to this group, send email to sage-devel@googlegroups.com. >> Visit this group at http://groups.google.com/group/sage-devel. >> For more options, visit https://groups.google.com/groups/opt_out. >> >> >> > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To post to this group, send email to sage-devel@googlegroups.com. > Visit this group at http://groups.google.com/group/sage-devel. > For more options, visit https://groups.google.com/groups/opt_out. > > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/groups/opt_out.
