leif wrote:
leif wrote:
John H Palmieri wrote:
Is there a ticket for the sage-sync-build problem?
Not yet. There are a couple of ways to (quickly or temporarily) "fix"
this:
1) Unmerge #14570, which doesn't fix a bug, but only introduces a new
(btw. non-configurable) feature. [A bit odd, especially since #14570
also patches the Cython spkg.]
2) Revert just #14570's change to setup.py, a one-liner (removing the
build_dir parameter to cythonize()). [Better than 1), although
effectively the same -- feature vanishes until we reenable it on some
follow-up ticket.]
diff --git a/setup.py b/setup.py
--- a/setup.py
+++ b/setup.py
@@ -532,7 +532,7 @@
ext_modules = cythonize(
ext_modules,
nthreads = int(os.environ.get('SAGE_NUM_THREADS', 0)),
- build_dir = 'build/cythonized',
+ # build_dir = 'build/cythonized',
force=force)
open(version_file, 'w').write(Cython.__version__)
works for me (with Sage 5.10.rc0).
3) Make the behaviour configurable (defaulting to the previous; little
change to setup.py). No breakage to ordinary users; people using the
new feature are expected to know what they're doing, i.e., at least
sage-sync-build [still] won't work for them. [IMHO preferable for a
temporary / quick fix; easy and safe.]
Similar to the above change, but with (say)
diff --git a/setup.py b/setup.py
--- a/setup.py
+++ b/setup.py
@@ -532,7 +532,7 @@
ext_modules = cythonize(
ext_modules,
nthreads = int(os.environ.get('SAGE_NUM_THREADS', 0)),
- build_dir = 'build/cythonized',
+ build_dir = 'build/cythonized' if
os.environ.get("BREAK_SAGE_SYNC_BUILD", "no")=="yes" else None,
force=force)
open(version_file, 'w').write(Cython.__version__)
which *optionally* enables building extension modules "out of tree"
(they're in fact in the same tree, but one level deeper, still
hard-coded location) at the expense of breaking (at least)
sage-sync-build. (Works for me, too.)
-leif
4) Minimally adapt sage-sync-build.py to reflect the (hard-coded) change
by #14570. [May be easy as well, but potentially unsafe.]
Even that turns out to be non-trivial, AFAICS, i.e., the whole strategy
would have to get changed, as opposed to just some file / directory
names in a few places.
-leif
I'd personally prefer 2) or 3) for now, postponing a "proper" solution
to a follow-up ticket which presumably won't make it into 5.10 (but
hopefully 5.11.*), as sage-sync-build needs some rework* anyway, the
Cython build directory (kind of VPATH) should IMHO be configurable, and
#14570 might cause further issues we haven't noticed yet.
-leif
__________
* the usual "can of worms"
--
() The ASCII Ribbon Campaign
/\ Help Cure HTML E-Mail
--
You received this message because you are subscribed to the Google Groups
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at http://groups.google.com/group/sage-devel?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
