Hey,
  I'm for accepting en masse since it is (mostly) self-contained, provided 
the doc builds cleanly too. From a skim-through of the patch, it seems like 
there is some documentation formatting I'd like to see changed (and some 
things that might be misformatted). However we can fix this up over time 
since this is minor compared to the functionality.

On Friday, May 24, 2013 2:22:35 AM UTC-7, Volker Braun wrote:
>
> I think the following needs to be addressed:
>   * segmentation faults due to recent changes in Sage
>   * either replace the private reimplementation of matrices or give a good 
> reason for why it is necessary
> Then it is imho ready for inclusion.
>

Wasn't the second point addressed in http://trac.sagemath.org/14627, so 
shouldn't the matrices be replaced?

Best,
Travis

PS - the extra c in Volcker makes your name sound ckooler :P

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at http://groups.google.com/group/sage-devel?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to