We should have a clear policy on this, because it's been a contentious issue in the past. I remember this came up once with regard to a patch I had refereed, which changed an error message in finite fields and thus broke the doctests in sage/tests/french_book/. The original fix was just to change the doctests, but the authors of the French book were very highly displeased by this and insisted that the code be changed back to match the book. (See tickets #8334 and #12084.)
It seems sensible to me that any file in the "tests" directory can have a nominated maintainer -- who should be clearly identified in the file header -- and the file should not be changed without consulting them. What do others think? If so, we should probably clarify this policy with a README file in sage/tests/. David On 18 May 2013 17:42, vdelecroix <20100.delecr...@gmail.com> wrote: > Hi William, > >> >> Because of #14568 some output of the tests in >> >> sage.tests.book_stein_ent changed. As they are the doctest of some >> >> book I wonder if there is something specific to do in that case ? >> >> > No, the convention is just to make appropriate changes to the output >> > as usual. This has happened to me. >> >> Well it would be nice if somebody would tell the author (me, in this >> case) so that they can update their book. Fortunately, I read >> sage-devel, so I caught this... > > Sure, it was not my intention to not inform the author !!! The patch > is still in an experimental version and it was just a precaution to > know if there is some special procedure to deal with sage.tests. > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To post to this group, send email to sage-devel@googlegroups.com. > Visit this group at http://groups.google.com/group/sage-devel?hl=en. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
