I must say that I saw the ticket and was about to review it, because nobody had done this so far. But I read Volker's comment, and I agree with him. Perhaps the reason for the failure of all of us to review this ticket is that not only Volker feels uncomfortable with such a change.
I don't know of any bad consequences of the approach taken, either. But here is the reason why I still disagree with it. On a functioning OS, we would expect the workaround to be unnecessary. Implementing a workaround for all OS's then is essentially equivalent to skipping part of the test, namely correct and timely shutdown of Sage. So we would sacrifice parts of test without need to. I also agree with Volker's argument on maintainability. On the other hand, I am sure it won't be the end of the world, if the ticket gets merged as is. I just wouldn't want to give a positive review to a ticket that I personally disagree with. Am Mittwoch, 24. April 2013 14:45:32 UTC+2 schrieb Jeroen Demeyer: > > On 04/24/2013 02:37 PM, Volker Braun wrote: > > For the record, I disagree with the approach to both #14371 and #14460 > > in that fugly workarounds to fundamental bugs in Solaris or a particular > > gcc version are applied liberally to, basically, everyone. Sure, > > sometimes it is necessary to work around bugs, but that should be a > > special case and not the generic code path. > > Do you know of actual bad consequences of the approach taken at #14371 > or #14460? I would not apply ugly workarounds to everyone *if* they have > bad consequences. If those workarounds don't really influence existing > working setups (which is the case with the mentioned patches), then > what's the problem? In this case, it's better to be safe and apply the > workaround on all systems. > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
