On Thu, Jan 31, 2013 at 2:36 AM, Volker Braun <vbraun.n...@gmail.com> wrote:
> On Thursday, January 31, 2013 10:31:16 AM UTC, Jeroen Demeyer wrote:
>>
>> I'd like to mention that in the release management script, there are a
>> few things that I check for, such as:
>>
>> * no bare "except:" without exception class
>> * no TABs
>> * no use of AssertionError ("assert" is fine, but not "except
>> AssertionError" for example)
>
>
> And thats great, but its the wrong place to check. The patch author should
> be immediately notified if his/her patch fails the automated checks, not
> weeks or months later.+1 I'm all for commit hooks, but that that's a developer convenience and may not be set up on every client. It would also be really easy to add a patchbot plugin to check for this (and it's also easy to look at a diff of the result, to ease us into it before all code is compliant http://patchbot.sagemath.org/log/10716/Fedora/18/x86_64/3.7.2-201.fc18.x86_64/volker-desktop.stp.dias.ie/2013-01-31%2014:11:19%20+0000?plugin=plugins.coverage&diff=/log/0/Fedora/18/x86_64/3.7.2-201.fc18.x86_64/volker-desktop.stp.dias.ie/2013-01-31%2010%3A38%3A07%20%2B0000&ticket=10716&base=5.7.beta2 ). I'd be happy to do this once we decide on a standard and have an (optional?) linter spkg. - Robert -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
