Hi Simon, > > If I understand correctly, we are talking here about "modifying" in the > sense of "removing stuff". IMHO, it would be totally > against the purpose of the pickle jar, if we would encourage (or just > explain how) to remove stuff from the pickle jar. > > If the pickle jar doc tests break then I think it is *not* the pickle > jar that needs to be updated. Instead, it is the unpickling methods that > need to be fixed. > > Actually, I think that you and I are talking about two different things: I am happy to maintain the pickle_jar whenever possible in the way the sage community wishes but I would really like this to be documented properly by the people who how know how it is supposed to work.
I removed these files from the pickle jar not because I wantonly wanted to destroy pickles but because I thought that this was the correct way to fix the problem - it does, after all, fix the doc tests. If this procedure was properly documented in the development guide, for example then we would not be having this conversation. Having said that I am happy to maintain old pickles, if it's possible, I should add that with my limited knowledge of pickles it does seem to me when a class is refactored (as here) then it will not always be possible to unpickle the old pickle because the new and old data structures may not be compatible. Perhaps I am being naive, however, as I am yet to figure out how register_unpickle_override works. Cheers, Andrew -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To post to this group, send email to sage-devel@googlegroups.com. To unsubscribe from this group, send email to sage-devel+unsubscr...@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel?hl=en.
