On Wednesday, September 19, 2012 12:09:34 PM UTC-7, Volker Braun wrote: > > +1 to: > > * rename v.normalization() -> v.normal_form() unless somebody has a better > name > * replace v.normalization() with he usual division by L2-norm. >
normal_form() is good, and to be standard with the other code packages I've seen, dividing by the L2-norm should be normalize(). > You can't deprecate the change gradually, but sometimes things have to > change to improve. > +1 I also think that giving a deprecation warning is a bad idea. First off this would likely mean a lot of docstring changes. Second, I feel that adds clutter (i.e. extra output) and unnecessary runtime for longer computations. I think we should have a (permanent) redirect to the normal_form() in the docstring of normalize(). Something like: If you wanted to divide by the leading term, instead call :meth:`normal_form`. Perhaps also a temporary warning in the docstrings about the change in functionality. Just my thoughts. Best, Travis -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To post to this group, send email to sage-devel@googlegroups.com. To unsubscribe from this group, send email to sage-devel+unsubscr...@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel?hl=en.
