On Tuesday, July 3, 2012 11:45:11 AM UTC-7, Justin C. Walker wrote: > > > On Jul 3, 2012, at 11:33 , John H Palmieri wrote: > > > > > > > On Tuesday, July 3, 2012 10:55:21 AM UTC-7, David Roe wrote: > >> > >> Hi everyone, > >> The new doctesting code (#12415) needs a change to the way Sage handles > >> temporary files, which is described at #13147. We can either > >> 1. change every use of temporary files within the sage library, or > >> 2. depend on the speaklater project and use a lazy string. > >> > >> Everyone working on the ticket thinks option 2 is the way to go. > >> Speaklater consists of a single python file and is already used in the > new > >> flask notebook (#11080) by including the python file. Rather than > >> introduce a strange dependency of sage on the notebook or to separately > >> include the python file in sage, I would like to propose including > >> speaklater as a separate spkg (which sagenb and sage would both depend > >> on). The spkg is 6.6K. > >> > >> So vote: > >> > >> > >> [ ] Include speaklater.py in sage without any doctests. > >> > > > > Does this choice have to be "include speaklater.py in both sage and > > sagenb", since sagenb uses it, and sagenb should function without the > Sage > > library? If that's right, then I'd prefer to avoid the code duplication, > > I don't see how it's "code duplication" if sagenb and sage are separate > entities. >
Sagenb would (as far as I understand) have to include the file speaklater.py. With the current proposal, the Sage library would also include the file speaklater.py. Isn't that code duplication? For comparison: note that there are two versions of sageinspect.py (not for long -- see trac #11913 and https://github.com/sagemath/sagenb/pull/62), one in sage/misc and one in sagenb/misc. They are supposed to be essentially the same (with a few differences in doctests reflecting different paths), but people have modified one without the other, they soon got out-of-sync, and this has caused problems. Putting (what is supposed to be) the same file in two packages is not a good idea, I think. -- John -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
