Julien, Sorry that I had not responded to this -- probably eclib issues should be in another thread.
Although I interpreted your "nifty" as positive, I take Jeroen's point about not using -Werror, but I'll leave in -Wall. On 7 April 2012 15:00, Julien Puydt <julien.pu...@laposte.net> wrote: > Le mardi 10 avril, John Cremona a écrit: >> If you are interested in taking a look, it is at >> http://homepages.warwick.ac.uk/staff/J.E.Cremona/ftp/progs/ (NB not >> yet an spkg) > > I configure-d, make-d and make check-ed it on x86_64 and on ARM : no > problem (and out of tree). Hooray! > > I had a look at the configure.ac ; it looks good, but I still > have two remarks : > (1) "-Wall -Werror" : nifty! > (2) is it even possible that a libm doesn't contain "cos"!? Perhaps I should take out that test for libm, and also the one for gmp, since it definitely will not build without a working NTL and pari (which will be the case with Sage), and eclib does not call gmp directly. > > I also read libsrc/Makefile.am : can't the file listed in > EXTRA_DIST be put in the various *_DOTHS? I could rename that variable as (say) extra_includes and add it to the DOTHS list. They are not header files though. > > In tests/Makefile.am : > (1) same remark about curvesort.cc in EXTRA_DIST ; OK > (3) the echo commands should perhaps be @echo, so we see the command > result and not the command. I have wondered how to do that for about 25 years, thanks! It never seemed so serious that I bothered to find out. > > I hope that helps, It certainly does. I'll make a new version and post it. Thanks a lot for the constructive comments. John > > Snark on #sagemath > > -- > To post to this group, send an email to sage-devel@googlegroups.com > To unsubscribe from this group, send an email to > sage-devel+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/sage-devel > URL: http://www.sagemath.org -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
