I think it's fine to change it, since we actively discourage users from
using is_* functions outside of library code.
David
On Mon, Apr 9, 2012 at 17:42, Niles Johnson <nil...@gmail.com> wrote:
>
> On Monday, April 9, 2012 5:02:45 PM UTC-4, Niles Johnson wrote:
>>
>> But I haven't found a Trac ticket for it -- could someone point it out to
>> me if it doesn't exist?
>>
>>
> Er, I mean, could someone point out a ticket if it *does* exist?
>
> Also, I've since learned that is_Graphics is used exactly once in the Sage
> library (not counting docstrings), in sage.misc.latex.png. There, it seems
> to be used for precisely the purpose I have in mind: to determine if an
> arbitrary object is "graphical", i.e. can be saved as an image file. If
> not, that function attempts to produce an image by typesetting the latex
> string representation of the object.
>
> So is anyone opposed to me changing the behavior of is_Graphics to return
> True for subclasses of GraphicsArray, Graphics3d, and Tachyon too? The
> docstring for is_Graphics simply says
>
> "Return True if x is a Graphics object." [1]
>
> To me, that seems vague enough that the change I'm describing could be
> interpreted as either "fixing" or "breaking" the function ("Graphics" is
> capitalized, but not hyperlinked). Is there a deprecation warning I should
> issue, or should I avoid the whole mess by defining a separate function?
>
> -Niles
>
> [1]
> http://www.sagemath.org/doc/reference/sage/plot/plot.html#sage.plot.plot.is_Graphics
>
> --
> To post to this group, send an email to sage-devel@googlegroups.com
> To unsubscribe from this group, send an email to
> sage-devel+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/sage-devel
> URL: http://www.sagemath.org
>
--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
