On Tue, Feb 28, 2012 at 7:49 PM, kcrisman <kcris...@gmail.com> wrote: > Some reasons for +1, in addition to Michael's (and I don't think that > a git switch would help much with his reasons, unless everyone had > access to the release manager's brain): > * What about a first-time contributor to Sage of brand-new code that > does something cool that no one "known" knows much about?
Depending on component, files touched, reviewer commitment, etc., there would be a suggested list of people to assign. As it is now, such users contribute their code and it goes into total limbo usually. > * What about someone who really doesn't know anybody? Exactly the same answer as above. > * What about situations where the reviewer quits Sage? It is easy with a query to find all "needs review" tickets with that person as a reviewer. Those tickets get set back to "needs work". If an author hasn't chosen an active reviewer, then they still have work to do. > * What about situations where the reviewer has a major family > emergency or for other reasons is too busy? Exactly the same answer as to the previous question. > * What about someone who knows who might be good, but doesn't know > them personally enough to do it? Exactly the same answer as to the previous question. > What about someone who doesn't know > about the list of "real names" on the first page of Trac? That's not relevant. See above. > Wait, wait, I just thought of a way to fix this! Everyone can put > William in the reviewer field. > > ;-) See above. If the selected reviewer takes no action on a ticket after n days, then the ticket is changed back to "needs work" (and a message is sent) -- it is then the responsibility of the author of the ticket to choose an active reviewer. >> -2 > > More seriously, I'd be very interested in the rationale for the -2. I > agree that the reason we don't get things reviewed is partly (only > partly) because people are less aggressive than they could be about > asking reviewers, but I don't see how adding people as reviewers on > the Trac page will change potential reviewers' behavior at all; if > anything, I'd be annoyed at being added because I already have > overcommitted myself on partial reviews of tickets I know I will not > be able to finish reviewing for a long time, but which really deserve > it (I'm looking at you, http://trac.sagemath.org/sage_trac/ticket/11028). If you do not have time to be a reviewer, then people won't have the option of nominating you to review their tickets. If you never or rarely review tickets, then listing you won't count (as explained above). -- William -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
