On Sat, Feb 25, 2012 at 10:28 AM, Daniel Krenn <kr...@aon.at> wrote: > I'm currently reviewing tickets #5491 and #12471. In both tickets the > patchbot for 4.8 (linux/ubuntu/hardy/sage.math.washington.edu) failed, > whereas the other two patchbots (one also for 4.8 and one for > 5.0.beta3) passed the test, see [1] and [2]. The tests on my computer > also passed. > > How do I proceed here? Giving a positive review?
I would test the code yourself and decide. And obviously look at the actual failures in each case. What to do should depend entirely on that. Also, 5.0.beta3 should trump 4.8. > > Daniel > > [1] http://patchbot.sagemath.org/ticket/5491/ > [2] http://patchbot.sagemath.org/ticket/12471/ > > -- > To post to this group, send an email to sage-devel@googlegroups.com > To unsubscribe from this group, send an email to > sage-devel+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/sage-devel > URL: http://www.sagemath.org -- William Stein Professor of Mathematics University of Washington http://wstein.org -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
