On Tue, Feb 7, 2012 at 12:08 PM, William Stein <wst...@gmail.com> wrote:
> On Tue, Feb 7, 2012 at 12:00 PM, Simon King <simon.k...@uni-jena.de> wrote:
>> Hi William,
>>
>> On 7 Feb., 20:47, William Stein <wst...@gmail.com> wrote:
>>> It's important (in fact, critical) that the trac ticket number is
>>> clearly available in the commit message. But having it twice in two
>>> different ways in almost every message seems a little bit sloppy to
>>> me.
>>
>> We were told, by different release managers, that the commit message
>> has to identify the ticket number. Patches not following the rule were
>> rejected.
>>
>> If that rule has changed in the meantime, the new rule ("Do not
>> mention the ticket number in your commit message!") should be enforced
>> in the same way as the old rule was enforced.
>
> I think the commit message should mention the ticket number. This
> makes it much easier to keep track of stuff, even before the release
> manager puts the code in Sage. E.g., I have a big patch queue of my
> own code, and I find the ticket numbers in commit messages useful.
>
> What I'm suggesting is that the script that auto-adds ticket numbers
> should strip the user-added ticket number first, to avoid extensive
> duplication.
Or at the very least not add it if it's not already there. (Stripping
it in all its variants might be hard.)
- Robert
--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
