On 27 Okt., 03:18, Jason Grout <jason-s...@creativetrax.com> wrote:
> As Florent pointed out, the maintenance burden would be huge.

Almost a one-liner for *both* fixing the whole Sage library as well as
all pending patches.


> Rejections for such an inconsequential bike-shedding issue that is
> just a matter of taste are a huge turn-off for a new developer.  The
> benefits are practically nil, as I see it.

It's regularly annoying to edit such lines.  I don't care much about
increased file size.


> I think the linux policy is
> sane---if you happen to be editing a line and remove the trailing
> whitespace, good for you.  But let's leave it at that.

But you won't get rid of them if you don't stop people
(re-)introducing them.  And it's similarly odd for reviewers to check
and perhaps fix such things again and again on tickets, producing
superfluous noise.

In general, if you want people to follow conventions, you should
remove all the grown counterexamples at some point, since people keep
copy-pasting and of course take present code as an orientation rather
than reading lengthy, perhaps boring guidelines.


> Sorry, I don't mean to be mean.  I just think there are far more
> important things that would help Sage, and I don't see any positives to
> rejecting patches by people for such an issue.

Of course.  Although we reject *any* tabs (in Python/Cython files)
regardless of their position.


2ct,

-leif

-- 
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to 
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org

Reply via email to