On 26 Aug., 07:05, John H Palmieri <jhpalmier...@gmail.com> wrote: > On Thursday, August 25, 2011 8:28:09 PM UTC-7, leif wrote: > > Well, uncommitted changes are committed upon root repo > > (re)installation anyway. (Same for scripts and the library IIRC; > > extcode for sure.) > > It tries to commit the changes, but since there are some "hg commit" > commands without the "-m" option specified, it tries to pop open an editor. > With emacs as the editor, this screws up the output to the screen, the log > for the relevant spkg, and in the end, the update. This is correctable, of > course.
Oh, missed that. Of course the build shouldn't be interactive. > > We should just ignore lines starting with "? " there, and IMHO only > > issue a warning if other changes remain; or prompt the user whether to > > commit or continue, or exit, unless a to-be-implemented "force" option > > was given. > > Why should we ignore lines starting with "? "? Perhaps the user wanted to > add the file. I don't see any reason to ignore these files, just like I > wouldn't see a reason to automatically add them to the repo. Ignoring them is IMHO ok since they won't have any effect on commits or pulls from the new repos, and also the converse, i.e., they'll just be left untouched. (And I guess in 99% of the cases "unknown" files are simply left-around ones, not intended to get added to a repo.) As kini suggested, we could log them to some file to be shown at the end of the build though, or (in case we prompt the user before really doing the upgrade) list them there in a warning before asking, too, but my point was that we shouldn't unconditionally abort upgrading if *only* "unknown" files are shown by 'hg status'. -leif -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
