On Mon, 25 Jul 2011 12:20:35 -0400 Michael Orlitzky <mich...@orlitzky.com> wrote:
> On 07/20/11 13:26, Burcin Erocal wrote: > > > > If you are adding tests only for integration, starting a new file > > sage/symbolic/tests.py might be better. > > > > ... > > > > Don't forget to mention the ticket number in the test. > > > > How's this looking? It is a good start. Here are some suggestions: - The code blocks should be preceeded with :: and indented. More information is available here: http://sagemath.org/doc/developer/conventions.html#documentation-strings - Since the file only contains integration tests, sage/symbolic/integration/tests.py is a better place for it IMHO. - I am not sure if a separate comment block is necessary for each test. I guess this makes sure that the test environment is always clean. It might add up to the time since it starts Sage so many times though. You can create a new ticket on trac and upload the patch there so it doesn't get lost. Thanks. Burcin -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
