I've been reviewing #10804, which was merged in sage-4.7.1.alpha0. I though this was a done deal... but apparently not. In the meantime, #10549 got a positive review. It conflicted with #10804. Jeroen, acting RM (for which I'm immensely grateful), backed out #10804 and marked both patches needs_work.
Now, I've gotta re-review #10804. I've already put in lots of time into this review so as long as tests pass, I'm gonna give a +1. The work's done, problem solved. No hard feelings (note: posting to sage-devel, not sage-flame). Fortunately, Robert was the author of both patches, but if that wasn't the case, I imagine both authors scrambling to rebase / re-review. Bottom line: I think this was handled wrong. If a ticket's been merged, unless it's found to have a genuine flaw, it should supersede (IMO) tickets with positive reviews which have not been merged. Thoughts? -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
