On 25 April 2011 15:25, Dima Pasechnik <dimp...@gmail.com> wrote:

>> > #ifndef ulong
>> > #define ulong unsigned long
>> > #endif
>
>> > would not be platform specific (so fairly easy to maintain).
>
> This does not work, as the header inclusion order in ZmodF_mul.c
> does #include ZmodF_poly.h (which includes stdio.h, which in turn
> includes sys/types.h containing the typedef for ulong)
> after ZmodF.h, which includes flint.h containing #define ulong
>
> Thus the typedef is nuked, and there is no way around it with the
> given header

I doubt Bill will change it, but personally I feel there's no need to
use ulong at all, and he should use "unsigned long" in his code. He
has invented something that saves 6 byes every time it is used, but
causes unnecessary complications.

I think the KISS principle should apply here.


Dave

-- 
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to 
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org

Reply via email to