Hi Alex, Contrary to Volker's good suggestion, I'll reply here, since it is something of a general question about submitting Sage code, and it might not get a reply on the ticket. ;-)
The code examples you have included in your *,sage file are intended to be part of the comprehensive test suite that gets checked regularly in Sage. While it is probably possible to run the tests using the standalone file you provided, most any developer who will review your code will find it easier to run tests after applying a patch, rebuilding Sage and then running the tests. Eventually your code *must* be a patch, and Sage must build and run when that patch is applied. So my comment was a rationale for learning how to package up your code in the form of a patch, since nobody else is likely to do it for you. But many (OK, some) will be willing to answer questions and help. Rob On Jan 4, 1:46 pm, Alex Raichev <tortoise.s...@gmail.com> wrote: > Hi Rob: > > Thanks for your comments on my ticket > (http://trac.sagemath.org/sage_trac/ticket/10519 > ). I'll rewrite the code incorporating your advice (uses objects, > update example formatting, etc.). > > You said something that i don't understand, though, namely "there is a > lot of checking that can't happen easily with a *.sage file." Can you > or someone else explain that? Are *.sage and *.py files different? > Should i be making *.py files instead? > > Thanks for your attention. > Alex > > On Dec 23 2010, 11:38 am, Alex Raichev <tortoise.s...@gmail.com> > wrote: > > > Thanks for the advice, Rob. Here's the Trac ticket URL for my first > > code submission to Sage. Woohoo! > > >http://trac.sagemath.org/sage_trac/ticket/10519 > > > For those interested in analytic combinatorics, check it out! > > > Alex > > > On Dec 22, 3:12 pm, Rob Beezer <goo...@beezer.cotse.net> wrote: > > > > Alex, > > > > Yes, that's right. You can post the Trac URL or just the ticket > > > number here if you would like to advertise it. Or you can add > > > relevant developers in the cc field of the ticket (maybe you have been > > > working on code written by another active developer who would be > > > interested). Choosing the right component (say combinatorics?) will > > > also make it visible to the right people. > > > > Be sure to post the code as a patch against a relatively recent > > > version of Sage or else it'll be difficult for anybody to go over it. > > > You'll have seen how to do that in the Developer's Guide. > > > > Rob > > > > On Dec 21, 2:31 pm, AlexRaichev<tortoise.s...@gmail.com> wrote: > > > > > Hi all: > > > > > I just finished documenting and testing some new Sage code related to > > > > analytic combinatorics. More specifically, the code is a collection > > > > of functions designed to compute asymptotics of Maclaurin coefficients > > > > of (special classes of) multivariate generating functions. > > > > > I'd like to share the code and get it peer reviewed. I read the Sage > > > > developer's guide and think that the next step in the development > > > > process is to submit the code to the Sage Trac server for review by > > > > opening a new ticket. Is that correct? > > > > > Thanks for your attention. > > > > Alex -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
