On Dec 6, 10:53 pm, Jason Grout <jason-s...@creativetrax.com> wrote: > Robert (and whoever else is working on the buildbot [1]), > > First of all, THANK YOU!!! This is amazing! I love how it is hooked up > to show the status on trac.
Indeed -- THANKS ! ! ! > > Could we add building documentation to the things that it checks for > each ticket? I have a couple of other feature requests/suggestions, which of course you're welcome to ignore since this is already great work! But if you're interested, here are my thoughts: 1. When I visit the buildbot page for a particular ticket, I think it would be useful to show, in addition to the build/test history, the list of patches which buildbot plans to apply on its next run -- this would help people verify that the correct attachments/dependencies are computed by buildbot without having to just wait for the next run. 2. It might be nice to know when buildbot plans to test the ticket next -- even a rough estimate would be helpful so that reviewers can determine if it would be more efficient for them to build and run tests themselves or wait for the buildbot 3. It seems that there are 2 or 3 tests that consistently fail, and which most people ignore for the purposes of reviewing (e.g. the startup.py test for startup time on sage.math.washington.edu). This means that probably no ticket will ever have "TestsPassed" status, and the "TestsFailed" status is less useful because it doesn't distinguish between failures which indicate a ticket needs more work and failures which should be ignored (for the purposes of reviewing, that is). I don't really want to reignite the debate about whether these tests should be modified or not, but perhaps buildbot could have a separate status when the only doctest failures are from among a certain set of files -- this would give more useful information to reviewers. 4. On a similar topic, I think someone else suggested that the failure summary from doctests could be posted directly to each buildbot ticket page -- for most people, that's probably the only part of the log that's really important. best, Niles > > [1]http://sage.math.washington.edu:21100/ticket/ -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
