On 30 November 2010 10:48, Jeroen Demeyer <jdeme...@cage.ugent.be> wrote: > On 2010-11-30 00:55, Volker Braun wrote: >> nobody wants to give a positive review until it has been tried on all >> platforms > > I think "testing on every platform" is not a necessary condition for a > ticket to receive positive_review. For reviewing a ticket, I think that > looking at the code is far more important than testing. If the ticket > gets positive_review, it will certainly get tested and any problems will > be caught. > > Jeroen.
IMHO, it should not be too hard for someone to test on one Linux system, one OS X system and one Solaris system. William has the hardware and will create accounts for people if they need to test Sage. Otherwise I fear too many positively reviewed tickets will end up getting bounced out for reasons that a bit of testing would have shown up much earlier. Of course, it also depends on the type of patch, and how large it is. Some are trivial. But certainly in the case of updating .spkg's, IMHO it's better if there's confirmation it wiorks on at least those three systems before giving a positive review. Testing on every Linux system is a different matter altogether though, and unfortunately it does seem that some tickets are getting stuck. because they build on one distribution, but not on another. Unfortunately, to make matters worst, there are no buildbots for some of the systems where Sage is breaking on. To be honest, I feel the only answer to that is that if someone wants Sage to build on a specific version of an OS, they need to make a buildbot available. It normally seems to be Fedora and openSUSE which get problems when people update their operating system. Dave -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
