The Cliquer package in Sage is presenting problems on Solaris in the way it builds a shared library.

I've looked briefly at what is supposed to be the unmodified Cliquer code, but there are endless modifications to the upstream source code.

Those modifications look very dubious too. For example, there are endless calls to malloc, but the programmer has not bothered to check if the calls to malloc fails or not. Those modifications are in sections specific to Sage, but there are similar examples in the upstream source code too.

The upstream source code does NOT create a shared library at all, so the *Sage* developer that has messed around to create a shared library has screwed up.

Perhaps it's just me, but when I see code where people can't be bothered to check if malloc fails or not, I suspect they have not taken much care elsewhere too.

Do we really need Cliquer in Sage?

Dave

--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to 
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org

Reply via email to