First, kudos to David Loeffler for implementing AdditiveAbelianGroup's (now in 4.5.2.alpha1) and to John Cremona and Jim Stankewicz for chasing through referee-ing the patches.
1. __call__ seems to chase its way up into the free module classes, where it fails in some constructions of quotient modules and generator matrices. In the "remember_generators" case would this be as simple as forming the right linear combination of the generators (which seems to work for me "by hand")? Or is there another way to construct individual elements? G = AdditiveAbelianGroup([3,4]) a = G((1,2)) Traceback (most recent call last): <snip> File "/sage/sage-4.5.2.alpha1/local/lib/python2.6/site-packages/sage/ modules/fg_pid/fgp_module.py", line 483, in __call__ raise TypeError, msg TypeError: length of v must be at most the number of rows of self 2. submodule() and is_submodule() seem to perform as expected and the former returns a group. Would implementing subgroups be about as simple as calling these routines? Rob -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org