On Sat, Jul 3, 2010 at 11:30 AM, William Stein <wst...@gmail.com> wrote: > On Saturday, July 3, 2010, Volker Braun <vbraun.n...@gmail.com> wrote: >> On Jul 3, 4:54 pm, Mike Hansen <mhan...@gmail.com> wrote: >>> 1) The src/ directory needs be under Mercurial version control. This >>> would increase the size of the spkgs by quite a bit. >> >> But you don't need to add all of src/. In fact, you could keep src >> in .hgignore and only selectively hg add the files that you actually >> want to modify in your patch. > > True.
I'm worried that it would be too easy to modify src and forget to add the file. Currently, one can safely nuke src and drop in the pristine upstream version. >>> 2) Many patches only need to be applied conditionally based on the >>> runtime environment. >> >> I would argue that such patches are fundamentally flawed as they can >> never become part of upstream. How hard is it to add an #ifdef bracket >> around your patch? +1 I still lean towards including GNU patch--who is stepping up to maintain the spkg for, say, the next two years (at least)? - Robert -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
