On 07/10/10 03:52 PM, John Cremona wrote:
I think it would be extremely difficult to list all doctests which
(directly or indirectly) use Singular.

I only used that as an example. R, Maxima etc could all do with this sort of thing. Something like Python, it would obviously not be practical.

Perhaps deleting Singular, then running doctests would allow one to generate a list of doctests which directly or indirectly call singular.

Just deleting singular, t

And, even if we could, then
every new doctest on every patch would have to be checked (who by?)

I was only thinking about when one updated the .spkg files really.

and if it used Singular then the Singular spkg would need updating
when that patch was applied!  Not practical.

I see what you are saying, so perhaps a wiki with the information might be 
better.

I was thinking similar things relating to pari instead of singular,
while working on the pari upgrade ticket #9343.  Testing the whole
library  is ok;  dealing with hundreds of (mainly trivial) failures is
just tedious.  Luckily major upgrades of major components such as
Singular or pari do not happen often.

John

Dave



On 10 July 2010 15:46, Dr. David Kirkby<david.kir...@onetel.net>  wrote:
Currently, if someone updates a package (e.g. Singular) and I want to review
that package, I can

  * Test if the new Singular builds on Solaris, OS X and Linux. If so
consider the new package OK.
  * Run all the doctests ($ make ptestlong) on all 3 platforms and be sure it
does not break anything. That's not really very practical - at least I'm not
willing to do it unless it was decided to be a rule, then everyone stuck to
it.

Much more useful would be to know exactly what doctests are related to
Singular, so which would be worth checking. At the moment, there is not to
my knowledge any such list, and I've no idea how to create one.

So a few questions.

  * Is there a quick way of finding out what doctests are used by Singular?
(Of course, I want to know for any package, not just Singular).

  * Would listing the doctests in SPKG.txt be sensible. So when someone
updates or reviews a package, they would see a simple list of all the
relevant doctests, in a section

== Relevant doctests ==

To me at least, such a list would be useful. Less easy is how to produce
such a list. One way might be to purposely corrupt the package (delete all
the singular libraries) and see what doctests fail. But that might not work
- it might simply stop Sage working. In which case, it would need someone
with expert knowledge to know what the doctests are.

As you can guess, I am proposing that such a section is added to SPKG.txt,
or at least the information could be found somewhere. But while we use
SPKG.txt, that would seem the sensible place to list them.

Dave

--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org



--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to 
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org

Reply via email to