On 07/ 1/10 05:26 AM, François Bissey wrote:
I must admit, I can't follow your patch - one obvious thing is that it would appear to print "MacIntel in 64 bit mode" whenever SAGE64 is set to yes. I've not actually applied your version. I'm actually sitting in bed now, and have given up coding today. So I will investigate tomorrow.My bad. I didn't see that. Having a 2 year old on your lap while doing stuff isn't great for concentration. Your patch effectively reproduce the settings of OSX 64 (except for the link flags) for any 64bits OS that isn't OSX 64. So I decided to consolidate: if os.environ['SAGE64']=="yes": env.Append( CFLAGS="-O2 -g -m64" ) env.Append( CXXFLAGS="-O2 -g -m64" ) env.Append( LINKFLAGS="-m64" ) if env['PLATFORM']=="darwin": env.Append( LINKFLAGS="-single_module -flat_namespace -undefined dynamic_lookup" ) --------------- In short add the flags on all platforms where SAGE64 is set (effect of your patch) then append the OSX specific stuff which happens to be the same in both 32 and 64 bits mode. Because we append we'll have the correct stuff for 64 bits OSX. Francois
Yes, that looks very clear. Would you mind making a real patch, attaching it and changing the author to you. Then I can review it. Ottherwise I need to find another reviewer.
Dave -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
