Dear David, These fixes sound great! Why not head on over to http://trac.sagemath.org/sage_trac/ and make yourself an account, open a ticket, and post a patch file there? This will require using Mercurial, which is easiest to use (if not familiar from elsewhere) via hg_scripts.[tab] from within Sage for the various Sage scripts.
- kcrisman On Jun 23, 9:05 am, "David Poetzsch-Heffter" <poetz...@itwm.fraunhofer.de> wrote: > Hi! > > I found (and fixed) a few Bugs in the file local/bin/sage-preparse. > > These are the things I fixed: > > * The module docstrings disappeared when preparsing because the > preparse_file function inserted those numeric_literals definitions before > the docstrings. > > * Now also unicode-docstrings (e.g. u"""foo""") are recognized as > docstrings. Also raw docstrings may now use an upper case R as string > modifier (R"""foo""" would work now) which is allowed in Python. > > * Now all coding-comments as specified by Python are found and excluded > from preparsing. > > * I did not fix a bug that occurs when a statement is on the same line > where the docstring ends (e.g. """foo"""; print 2^5). It will not be > preparsed! I added a TODO-comment on the according line. > > I don't know if I am allowed to attach files here, so I'm going to host > the diff and my fixed version of the file elsewhere: > > http://spielwiese.hsg-kl.de/~cui/bug-fix-preparse/ > > Included is the original file as of sage version 4.4 on opensuse 64bit, > the file that contains my bugfixes and a diff file of those two. > > greetings, > David Poetzsch-Heffter. > > PS: If I am allowed to attach files, the named files come also attached > with this e-mail. > > sage-preparse.bugfix > 12KViewDownload > > sage-preparse.diff > 3KViewDownload > > sage-preparse.orig-4.4 > 10KViewDownload -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
