On Sat, Jun 12, 2010 at 5:04 AM, Alex Ghitza <aghi...@gmail.com> wrote: > > Dear sage-devels, > > The directory sage/databases has a dismal coverage score of 34.6%, and > a lot of the code is part of revision 0 in the hg repository (aka > sage-0.10.12 aka the Jurassic era). This makes it rather fun to > document, and I've run into a few things on which I'd like to get some > clarifications. > > 1. It seems to me that kohel.py is broken and has not been used in the > past 5 years or so.
Then I suppose we should remove it, unless David Kohel has objections. > 2. The various database classes' __init__ method takes an optional > parameter read_only which is set to True by default. However, this gets > passed to the __init__ method of Database, which ignores it whenever the > database is given a name (so, in our case, always). For instance: > > sage: c = ConwayPolynomials(read_only=True) > sage: c.read_only > False Being read_only is only for safety. It would be good to fix the above issue. Open a ticket. > 3. The coverage script complains (as usual) about the lack of a > TestSuite test. Not surprising, given that all that code was written before TestSuite. > The only test that is run for these classes inheriting > from Database is _test_pickling(), and this fails. Is this something > that we should look into fixing, or does is just not make sense to > pickle a Database? Good question. I think the more things we can pickle the better. This helps with parallel programming, among other things. Pickling could at least assume the database files are available on disk though. > 4. Is tables.py now superseded by cremona.py and odlyzko.py? Yes, I think so. William > > -- > Alex Ghitza -- http://aghitza.org/ > Lecturer in Mathematics -- The University of Melbourne -- Australia > > -- > To post to this group, send an email to sage-devel@googlegroups.com > To unsubscribe from this group, send an email to > sage-devel+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/sage-devel > URL: http://www.sagemath.org > -- William Stein Professor of Mathematics University of Washington http://wstein.org -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
