On Fri, Jan 29, 2010 at 6:27 AM, Minh Nguyen <nguyenmi...@gmail.com> wrote: > Hi folks, > > On Fri, Jan 29, 2010 at 9:09 PM, Minh Nguyen <nguyenmi...@gmail.com> wrote: > > <SNIP> > >> A problem with cddlib-094f.p2.spkg is that it patches upstream source >> using a patch file, rather than copying a patched file over to the >> appropriate place under the src/ directory. Consequently, there is no >> clean separation between upstream source and patches that we apply to >> cddlib-094f. > > I just want to clarify some points about my previous email. > > * I'm not arguing that the command "patch" should never be used in the > installation script of an spkg. You can use it if you wish, but please > be careful not to mix and match. Try to be consistent across the whole > spkg-install file.
I think the command "patch" should absolutely never, ever be used in the installation script of an spkg. There are platforms that don't have patch preinstalled, and it is not a prerequisite for installing Sage (according to the README). It is also simply not necessary as you explained. --William > > * When you're packaging an spkg, ensure that your patch(es) are not > already applied to the relevant files under src/. This is the case > with cddlib-094f.p2.spkg, which has modified source under src/. The > patching process should be done during the (re)installation of the > spkg. > > Thanks to Willem Jan Palenstijn for clarifying my thoughts on the > subject of this thread. In the same spirit as ticket #8079 [1], I'm > more interested in documenting best practices for patching spkg's. > > [1] http://trac.sagemath.org/sage_trac/ticket/8079 > > -- > Regards > Minh Van Nguyen > > -- > To post to this group, send an email to sage-devel@googlegroups.com > To unsubscribe from this group, send an email to > sage-devel+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/sage-devel > URL: http://www.sagemath.org > -- William Stein Associate Professor of Mathematics University of Washington http://wstein.org -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
