Hi Nicolas, On Jan 27, 10:28 pm, "Nicolas M. Thiery" <nicolas.thi...@u-psud.fr> wrote: > * Puts all permutation groups and some other finite groups in the > corresponding categories. There remains to handle finite matrix > groups and Galois groups in sage/rings/number_field/. > > * As a result, this standardizes the interface of those groups > (cardinality, one, ...).
Nice! I recently had some trouble trying to sort out where to put the conjugacy classes code, this will be really helpful! I can't really comment on the graph stuff, but since I'll have to rebase the cc-patches anyway I might as well give a look to this one. Which brings to the discussion: is there a standard way of reviewing tickets? I imagine you all sage gurus have your systematic ways perfected over the years. But what are precisely those steps? For instance, something like: 1. Update sage to the latest version with sage -upgrade 2. Make a clone for testing patches with sage -clone testing 3. Apply the patch you want to review using... etc. I checked in the developers wiki http://wiki.sagemath.org/devel/TracGuidelines but the suggestions are rather terse. How does one check 100% doctests? It would be great it it could be upgraded with more detailed instructions. Cheers J -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
