On Thu, Jan 21, 2010 at 7:32 AM, mhampton <hampto...@gmail.com> wrote:
> I would like to encourage people to review ticket 7109:
>
> http://trac.sagemath.org/sage_trac/ticket/7109
>
> This was originally submitted by Volker Braun, and I think it is his
> first contribution to Sage. It is an important refactoring of the
> polyhedra code in geometry/polyhedra.py. This rewrite is much
> cleaner, easier to extend in the future, and fixes a number of bugs in
> my original code (for example: tickets 6915, 6214, and 5134 will all
> be closed by this I think).
>
> Because of some lack of doctests and breaks in backwards-
> compatibility, I added and changed a substantial amount to Volker's
> original patch. But now I feel I shouldn't give it a positive
> review. So I am asking that someone else check it out.
>
> I don't think you need to be an expert in polyhedra, just familiar
> with the Sage review process. I have tested the new functions pretty
> heavily, and while they are slower in some cases this is dramatically
> outweighed by the bugfixes.
>
> I think this will be a big advance in the polyhedra functionality in
> Sage.
I see this on the patches:
* cddlib-094f.spkg Download (1.8 MB) - added by vbraun 3 months ago.
cdd_both_reps now reports timing information for individual operations
* trac_7109_mh1.patch Download (212.8 KB) - added by mhampton 3 weeks ago.
Based against 4.2.1, cumulative of all changes except cddlib spkg
It would be nice if there were a "referee patch" which gets applied
after vbraun's patch. Then one could see what you did, and what you
already refereed. As it is, one has to basically start from scratch.
-- William
--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
