On Tue, Oct 13, 2009 at 10:12 AM, ma...@mendelu.cz <ma...@mendelu.cz> wrote: > > Hello all > > This is for developers interested in Calculus. > > Since the patch for #385 is available and seems to work for me, I > finished my work on #6479 > > You have to use 2 patches from #6479 and one patch from #385 > > After this we have the following enhancements in Sage: > > * Fixed #6479 (bad solution of IVP for second order ODE) > * Desolve_laplace is more sage-like > * Current desolve_laplace keeps initial condition in the system. This > unintended behavior has been fixed. > * We can solve Lagrange, Clairot, Bessel and other equations > * Added support and examples for Runge Kutta methods > * desolve with show_method=True outputs the type of the ODE (linear, > separable, bernoulli, ....) > * ic2 and bc2 functions from Maxima do not have bug described at > http://thread.gmane.org/gmane.comp.mathematics.maxima.general/28434 > > > If you think that it is useful, please review it. It would be nice to > find it in the next releases. > > It is my first patch for Sage. If something does not satisfy the usual > conditions for patches, feel free to let me know or repaire. My last > desolvers.py is at http://user.mendelu.cz/marik/temp/desolvers.py
I've just had a brief look. The improvements are *fantastic*! However, some of the docstrings do not follow proper format. For example, in your desolve_rk4 function, you do not indent the Sage code in the EXAMPLES section correctly. Also, if a function can produce different types of output (eg, a plot or a list of points, depending on the optional parameters), both should be illustrated in the examples. I don't know if this improper formatting screws up the sage -test script or not. Please fix these. The description of the ticket should make it clearer exactly which patches to apply and in which order. I figured this out form your email, but the release manager needs this info on the ticket itself. If you decide to fix these "stylistic" issues, I'll play with the code more before writing a review/referee comment on the ticket itself. > > I think that documentation needs some revision. I was confused from > all these Sage directories. Is the right file for this sage/devel/sage/ > doc/en/constructions/calculus.rst ? Or is this file autogenerated from > some other file? > > Thank you for your help during my work on these patches and thank you > also for Sage :) > > Robert Marik > > > --~--~---------~--~----~------------~-------~--~----~ To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org -~----------~----~----~----~------~----~------~--~---
