Minh Nguyen wrote:
> On Mon, Sep 14, 2009 at 4:17 AM, William Stein <wst...@gmail.com> wrote:
>
> <SNIP>
>
>> OK, I also posted a review with several specific comments about the
>> spkg-install, which do include Kirkby's.
>
> An updated spkg is up at ticket #6681
>
> http://trac.sagemath.org/sage_trac/ticket/6681
>
> It addresses all of the reviewers' comments.
>
I looked at it and see a small problem. The script has somewhere near
the top 'set -e', which is good, as it will cause the script to exit if
there is an error.
However, if 'make' fails, the script will exit, so
if [ $? -ne 0 ]; then
echo "Failed to compile cliquer... exiting"
exit 1
fi
will never get executed.
Hence I think spkg-install needs changing to put a 'set +e' and a 'set
-e' around the block. So:
set +e
make
if [ $? -ne 0 ]; then
echo "Failed to compile cliquer... exiting"
exit 1
fi
set -e
will ensure that the spkg-install will not exit immediately if 'make'
fails, but it will issue an informative error before exiting.
--~--~---------~--~----~------------~-------~--~----~
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to
sage-devel-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
-~----------~----~----~----~------~----~------~--~---
