Hi Simon, On Fri, Aug 28, 2009 at 8:48 PM, Simon King<[email protected]> wrote:
<SNIP> > For the record: John Palmieri reported that the spkg now builds fine > on Intel Mac, both 32 and 64 bit, and whether "MAKE" is set to "make - > j2" or not. Cool! Good to know. > Failing doc tests are apparently due to using unsorted > dictionaries or sets, but this should be easy to fix. I suspect those failed doctests should be easy to fix. Don't take my words for it, since I don't have access to a Mac. > Thank you very much for all your hints! > > But back to my original question to William: > Does it suffice if the Intel Mac problem reported by John is fixed and > the spkg still builds on sage.math, or do you think the package should > (after fixing the set/dictionary doc tests) be tested on your whole > build park? Or would you leave this decision to the reviewers? The top-level README.txt claims that Sage is regularly tested on the following platforms: PROCESSOR OPERATING SYSTEM x86 32-bit Linux -- Debian, Ubuntu, CentOS (=Redhat), Fedora Core, OpenSuse, Mandriva x86_64 64-bit Linux -- Debian, Ubuntu, CentOS (=Redhat), Fedora Core, OpenSuse, Mandriva ia64 itanium2 64-bit Linux -- Redhat, Suse x86 Apple Mac OS X 10.5.x ppc Apple Mac OS X 10.5.x So it really depends on one's access to any of these platforms. All a reviewer can say is that something works on those platforms that they have access to. If a patch is specific to Mac OS X, then the person can review the code. But to actually test the code in practice, someone needs to take it on a test drive on a Mac box. Testing on all supported platforms should happen before announcing the stable release, as doing so catches any platform-specific problems. In the end, it boils down to people and the release manager(s) having access to a build farm or different platforms for testing. I don't have access to a Mac box, so I rely on other people to test Mac specific code. -- Regards Minh Van Nguyen --~--~---------~--~----~------------~-------~--~----~ To post to this group, send an email to [email protected] To unsubscribe from this group, send an email to [email protected] For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~----------~----~----~----~------~----~------~--~---
