Minh Nguyen wrote: > Hi David, > > On Tue, Aug 4, 2009 at 8:32 PM, David Kirkby<david.kir...@onetel.net> > wrote: >> >> 2009/8/4 Minh Nguyen <nguyenmi...@gmail.com>: >>> >>> Hi folks, >>> >>> Michael Abshoff has complained before about using non-ASCII characters >>> in patches. Today, I experienced first-hand why he complained. The >>> thing is, if a Sage library file contains non-ASCII characters, this >>> can result in errors or warnings when loading Sage. I recently merged >>> #5793, which has a patch that contains non-ASCII characters. As a >>> follow-up to that ticket, I created #6674 >>> >>> http://trac.sagemath.org/sage_trac/ticket/6674 >>> >>> in order to fix that issue. The non-ASCII character issue should be >>> fixed before releasing Sage 4.1.1. Who would like to volunteer to >>> review #6674? >>> >>> -- >>> Regards >>> Minh Van Nguyen >> >> I agree non-ASCII characters cause problems. I was intending reviewing >> it for you, as it is clearly a very trivial fix. However, you have >> replaced the first letter of the name with the letter 'O'. At least >> when I view it, it looks more like an 'A' and an 'O'. Clearly it can't >> be represented accurately, but is an 'A' more appropriate than an 'O'? > > It looks like an "O" to me. I referred to this page > > http://users.tkk.fi/pat/cliquer.html > > which is the homepage of the software in question.
An O with double dots is definitely not an A. It might be represented as "Oe" (though I'm open for correction about the usual practice in from Swedish/Finnish people). I don't know whether Sage has made a decision to be ASCII-only; in that case please disregard the below, but: When it comes to the warnings, it is quite trivial to add a header at the top of the py file: # encoding: utf-8 (or whatever encoding one is using -- standardizing on utf-8 is probably a good idea). I don't see why one should restrict oneself to ASCII in this day and age, when the names of many contributors will NOT be representable as ASCII. Dag Sverre --~--~---------~--~----~------------~-------~--~----~ To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~----------~----~----~----~------~----~------~--~---
