On Tue, Jul 21, 2009 at 11:59 AM, Tim Dumol<timdu...@gmail.com> wrote: > > I think I'm done with the migration to Jinja -- at least for > notebook.py.
Wow, nice. You're a machine. (that's a complement). If your patches don't get reviewed promptly, please bug me. William > I'll take a peek at the rest of the files, and then > delete the orphaned functions later. > > On Jul 21, 6:42 pm, Tim Dumol <timdu...@gmail.com> wrote: >> I find the template code used as a bit kludgy, and I've only done a >> few tests on it. I'll look over it again and write a few proper tests >> first, I think. >> >> Oh, and I see that Ondrej Certik is doing work on the notebook as well >> (http://groups.google.com/group/sage-devel/browse_thread/thread/65ca1e... >> ). I think that this template code could be helpful for his work, >> since Jinja is pretty easy to convert to Django. I think I'll convert >> the rest of the notebook to Jinja, and see if I can collaborate with >> him -- fork his github project, or the like. >> >> On Jul 21, 2:54 am, William Stein <wst...@gmail.com> wrote: >> >> > On Mon, Jul 20, 2009 at 10:37 AM, Tim Dumol<timdu...@gmail.com> wrote: >> >> > > I've started a ticket on it >> > > (http://trac.sagemath.org/sage_trac/ticket/6568 >> > > ) and uploaded a small patch implementing the migration of a few >> > > functions in notebook.py to Jinja -- although not in idiomatic Jinja, >> > > to be done later. >> >> > Why is it "with patch; not ready for review"? If the patch is applied >> > will everything work? It's often *very* good to do thing in small >> > increments, since it makes refereeing much easier. >> >> > I did just look over your patch for #6568 and it looked very good to me. >> >> > -- William >> >> > > On Jul 20, 2:12 am, William Stein <wst...@gmail.com> wrote: >> > >> On Sun, Jul 19, 2009 at 9:47 AM, timdumol<timdu...@gmail.com> wrote: >> >> > >> > I saw a previous proposal to migrate the HTML strings in Notebook to >> > >> > Jinja, a templating engine ( >> > >> >http://groups.google.com/group/sage-devel/browse_thread/thread/a73c88... >> > >> > ), but this was a year ago, and I still see that the Notebook still >> > >> > uses HTML strings. >> >> > >> > Jinja is a templating engine based on Django's. It's already included >> > >> > in Sage due to the inclusion of Sphinx. Migrating from HTML to >> > >> > templates should make it easier to make future changes to the code, >> > >> > and make things easier to read. >> >> > >> > I am willing to work on migrating the Notebook to Jinja in my spare >> > >> > time. What do you guys think? >> >> > >> Go for it! >> >> > >> -- >> > >> William Stein >> > >> Associate Professor of Mathematics >> > >> University of Washingtonhttp://wstein.org >> >> > -- >> > William Stein >> > Associate Professor of Mathematics >> > University of Washingtonhttp://wstein.org > > > -- William Stein Associate Professor of Mathematics University of Washington http://wstein.org --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to sage-devel-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~----------~----~----~----~------~----~------~--~---
