I have given a positive review. I didn't do a huge amount of testing but it seems like a very straightforward patch.
-Marshall On Jun 2, 3:34 am, William Cauchois <[email protected]> wrote: > A fix is up at <http://trac.sagemath.org/sage_trac/ticket/6184>, and > needs a review! > > On Mon, Jun 1, 2009 at 12:51 AM, William Cauchois > > <[email protected]> wrote: > > I looked into this, and I found that the mesh=True property is > > supposed to be passed via RenderParams to jmol_repr(). However, this > > isn't happening. Graphics3d.export_jmol (which is invoked by show()) > > has a keyword parameter for mesh, but it is never referenced in the > > body of the function. I think that setting simply render_params.mesh = > > mesh after render_params is initialized should do the trick. Does > > anybody know where/how this functionality was broken? > > > (Also it looks like dots may be broken as well?) > > > I will open a ticket tomorrow and submit a patch. > > > -- Bill > > > On Sat, May 30, 2009 at 5:10 PM, Alex Ghitza <[email protected]> wrote: > >> I have tried this in 3.4.1, 3.4.2, and 4.0.rc2, without success: > > >> plot3d(lambda x,y: exp(x+y*I).real(), (-2, 2.4), (-3, 3), mesh=True) > > >> I get a nice looking surface (see attached jpeg file), but no mesh > >> lines. Is anybody else experiencing this? > > >> Best, > >> Alex > > >> -- > >> Alex Ghitza -- Lecturer in Mathematics -- The University of Melbourne > >> -- Australia --http://www.ms.unimelb.edu.au/~aghitza/ --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~----------~----~----~----~------~----~------~--~---
