Dear Robert,
Could you please review http://sagetrac.org/sage_trac/ticket/5979
It's very short but quite sensitive.
sage -testall passes smoothly with sage-3.4.2-alpha0 (except for a
trivial broken test in interfaces.r which also fails before applying
the patch). Haven't tried it with sage-3.4.2 final (under compilation)
Thanks!
Nicolas
------------------------------------------------------------------------------
In Parent, there is a (previously implicit) invariant, namely that:
self._element_init_pass_parent == guess_pass_parent(between
._element_constructor)
This invariant was broken when self._element_constructor was set from
self._element_constructor_ by __call__. This made the parent not to be
passed properly to _element_constructor.
This patch fixes this (one line), and adds a corresponding doctest.
It also includes a related trivial fix to a line that is apparently never used
in coerce_maps, and adds a comment about this.
The category patch #5891 depends heavily on this one, as this way of
setting _element_constructor becomes the default one for simple
parents.
------------------------------------------------------------------------------
--
Nicolas M. Thiéry "Isil" <nthi...@users.sf.net>
http://Nicolas.Thiery.name/
--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to
sage-devel-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~----------~----~----~----~------~----~------~--~---
